Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch_bignumeric attribute #1500

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

startork
Copy link

Related to #1498

Add in optional bignumeric attribute which converts sql bigints to php ints and sql decimal and numeric to php float

Add basic tests for string vs int/float returns

Add in optional bignumeric attribute which converts sql bigints to php ints and sql decimal and numeric to php float

Add basic tests for string vs int/float returns
@startork
Copy link
Author

Hi @v-makouz
Would you be able to give me some advice? I'm unsure whether to
a) Treat bigints as integers straight from the start, using c++ long long types or
b) to handle similar to datetime, keeping existing code as much as possible and only converting to int when required as a zval.

Thanks,
Starsky

@startork startork marked this pull request as draft January 24, 2024 10:43
@v-makouz
Copy link
Contributor

v-makouz commented Feb 1, 2024

I think treating it like datetime would be more straightforward. But I see there are still some automated test fails, like the "Numeric value out of range"

@vaishnavyogesh vaishnavyogesh mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants